ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

spirv: disable frem and fmod tests for now (#1614)

Browse Source 
The OpenCL SPIR-V Environment Specification does not require the SPIR-V
opcodes `OpFMod` and `OpFRem` to match any OpenCL C semantics, so
implementations implementing those two instructions according to Vulkan
and/or OpenGL semantics will fail those tests without actually violating
any OpenCL specification.

We should keep those tests disabled until we figure out what the actual
precision requierement should be and update the test accordingly.

Signed-off-by: Karol Herbst <kherbst@redhat.com>
This commit is contained in:
Karol Herbst
2023-02-07 18:08:29 +01:00
committed by GitHub
parent 1e5b5c96e2
commit b81b49e10e
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test_conformance/spirv_new/test_op_fmath.cpp
View File

@@ -173,13 +173,14 @@ int test_fmath(cl_device_id deviceID,
lhs, rhs); \
}
#define TEST_FMATH_MODE(TYPE, MODE) \
TEST_FMATH_FUNC(TYPE, fadd, MODE) \
TEST_FMATH_FUNC(TYPE, fsub, MODE) \
TEST_FMATH_FUNC(TYPE, fmul, MODE) \
TEST_FMATH_FUNC(TYPE, fdiv, MODE) \
TEST_FMATH_FUNC(TYPE, frem, MODE) \
TEST_FMATH_FUNC(TYPE, fmod, MODE) \
#define TEST_FMATH_MODE(TYPE, MODE) \
TEST_FMATH_FUNC(TYPE, fadd, MODE) \
TEST_FMATH_FUNC(TYPE, fsub, MODE) \
TEST_FMATH_FUNC(TYPE, fmul, MODE) \
TEST_FMATH_FUNC(TYPE, fdiv, MODE) \
// disable those tests until we figure out what the precision requierements are
// TEST_FMATH_FUNC(TYPE, frem, MODE) \
// TEST_FMATH_FUNC(TYPE, fmod, MODE) \
#define TEST_FMATH_TYPE(TYPE) \
TEST_FMATH_MODE(TYPE, regular) \