From b81b49e10e18ad5b059a3e3af51b209373c1c7aa Mon Sep 17 00:00:00 2001 From: Karol Herbst Date: Tue, 7 Feb 2023 18:08:29 +0100 Subject: [PATCH] spirv: disable frem and fmod tests for now (#1614) The OpenCL SPIR-V Environment Specification does not require the SPIR-V opcodes `OpFMod` and `OpFRem` to match any OpenCL C semantics, so implementations implementing those two instructions according to Vulkan and/or OpenGL semantics will fail those tests without actually violating any OpenCL specification. We should keep those tests disabled until we figure out what the actual precision requierement should be and update the test accordingly. Signed-off-by: Karol Herbst --- test_conformance/spirv_new/test_op_fmath.cpp | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/test_conformance/spirv_new/test_op_fmath.cpp b/test_conformance/spirv_new/test_op_fmath.cpp index 61e2864d..853bab38 100644 --- a/test_conformance/spirv_new/test_op_fmath.cpp +++ b/test_conformance/spirv_new/test_op_fmath.cpp @@ -173,13 +173,14 @@ int test_fmath(cl_device_id deviceID, lhs, rhs); \ } -#define TEST_FMATH_MODE(TYPE, MODE) \ - TEST_FMATH_FUNC(TYPE, fadd, MODE) \ - TEST_FMATH_FUNC(TYPE, fsub, MODE) \ - TEST_FMATH_FUNC(TYPE, fmul, MODE) \ - TEST_FMATH_FUNC(TYPE, fdiv, MODE) \ - TEST_FMATH_FUNC(TYPE, frem, MODE) \ - TEST_FMATH_FUNC(TYPE, fmod, MODE) \ +#define TEST_FMATH_MODE(TYPE, MODE) \ + TEST_FMATH_FUNC(TYPE, fadd, MODE) \ + TEST_FMATH_FUNC(TYPE, fsub, MODE) \ + TEST_FMATH_FUNC(TYPE, fmul, MODE) \ + TEST_FMATH_FUNC(TYPE, fdiv, MODE) \ +// disable those tests until we figure out what the precision requierements are +// TEST_FMATH_FUNC(TYPE, frem, MODE) \ +// TEST_FMATH_FUNC(TYPE, fmod, MODE) \ #define TEST_FMATH_TYPE(TYPE) \ TEST_FMATH_MODE(TYPE, regular) \