ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix sub_group_ballot_find_msb/lsb tests (#1411)

Browse Source 
As per the OpenCL Extension Specification § 38.6 Ballots:

   If no bits representing predicate values from all work items in
   the subgroup are set in the bitfield value then the return value
   is undefined.

The case with no bits set is still worth testing, as it does not result
in undefined behavior, but only an undefined return value.

Signed-off-by: Stuart Brady <stuart.brady@arm.com>
This commit is contained in:
Stuart Brady
2022-04-04 17:57:36 +01:00
committed by GitHub
parent 93f4f6a548
commit e121b9d1bf
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test_conformance/subgroups/test_subgroup_ballot.cpp
View File

@@ -609,6 +609,12 @@ template <typename Ty, BallotOp operation> struct BALLOT_COUNT_SCAN_FIND
}
else if (operation == BallotOp::ballot_find_lsb)
{
if (bs.none())
{
// Return value is undefined when no bits are set,
// so skip validation:
continue;
}
for (int id = 0; id < sbs; ++id)
{
if (bs.test(id))
@@ -630,6 +636,12 @@ template <typename Ty, BallotOp operation> struct BALLOT_COUNT_SCAN_FIND
}
else if (operation == BallotOp::ballot_find_msb)
{
if (bs.none())
{
// Return value is undefined when no bits are set,
// so skip validation:
continue;
}
for (int id = sbs - 1; id >= 0; --id)
{
if (bs.test(id))