ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

relationals: fix out of bounds accesses in shuffle test (#1961)

Browse Source 
The values in `src` are indices into an array in `get_order_string()`.
Not initializing `src` resulted in out of bounds accesses there.

It seems that when the out of bounds accesses happened, the result of
`get_order_string()` was not actually used, so at least the test was not
using random data. Fix the issue as it prevents a clean run of this test
with e.g. AddressSanitizer.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2024-06-04 18:38:44 +02:00
committed by GitHub
parent 556025ba14
commit a130f3d179
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
test_conformance/relationals/test_shuffles.cpp
View File

@@ -882,7 +882,8 @@ int test_shuffle_random(cl_device_id device, cl_context context, cl_command_queu
int numTests = NUM_TESTS*NUM_ITERATIONS_PER_TEST;
for( int i = 0; i < numTests /*&& error == 0*/; i++ )
{
ShuffleOrder src, dst;
ShuffleOrder src{ 0 };
ShuffleOrder dst;
if( shuffleMode == kBuiltInFnMode )
{
build_random_shuffle_order( dst, vecSizes[ dstIdx ], vecSizes[ srcIdx ], true, d );