mirror of
https://github.com/KhronosGroup/OpenCL-CTS.git
synced 2026-03-19 06:09:01 +00:00
5bb4d089dd
* Specify GCC flag `-frounding-math` on x86 We have been seeing fails in `test_conversions` on x86_64 when converting to the following integer types from `cl_double` with a non-default rounding mode: ``` char_rtn_double char_rtp_double int_rtn_double int_rtp_double long_rtn_double long_rtp_double long_sat_rtn_double long_sat_rtp_double short_rtn_double short_rtp_double uchar_rtp_double uint_rtp_double ulong_rtp_double ushort_rtp_double ``` After investigation it was discovered that `rint()` was incorrectly rounding `cl_double` inputs despite the rounding mode being correctly set using `fesetround()` beforehand. E.g For 'char_rtn_double' `-3.5` was getting rounding to `-3.0` rather than `-4.0`. This is a gcc issue https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92164 when using the builtin `rint()` implementation, rather than `std::rint()`, that only presents itself when compiling a Release build with `-O2` rather than Debug. Adding the compiler flag `-fno-builtin-rint` to the CMake works around this problem, however based on the discussion in the gcc ticket using `-frounding-math` appears to be a more comprehensive fix. As `-frounding-math` tells gcc that the code will be modifying the rounding mode, removing the assumption that the same rounding mode is in effect everywhere. * Set FENV_ACCESS ON in rounding_mode.h Inform compilers which are aware of the `FENV_ACCESS` pragma that TUs which include `harness/rounding_mode.h` may manipulate the floating point environment. * Remove FENV_ACCESS pragma from test_conversions.cpp This pragma is now set in the included header `test_common/harness/rounding_mode.h` Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
64 lines
1.4 KiB
C
64 lines
1.4 KiB
C
//
|
|
// Copyright (c) 2017 The Khronos Group Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
#ifndef __ROUNDING_MODE_H__
|
|
#define __ROUNDING_MODE_H__
|
|
|
|
#pragma STDC FENV_ACCESS ON
|
|
|
|
#include "compat.h"
|
|
|
|
#if (defined(_WIN32) && defined (_MSC_VER))
|
|
#include "errorHelpers.h"
|
|
#include "testHarness.h"
|
|
#endif
|
|
|
|
typedef enum
|
|
{
|
|
kDefaultRoundingMode = 0,
|
|
kRoundToNearestEven,
|
|
kRoundUp,
|
|
kRoundDown,
|
|
kRoundTowardZero,
|
|
|
|
kRoundingModeCount
|
|
}RoundingMode;
|
|
|
|
typedef enum
|
|
{
|
|
kuchar = 0,
|
|
kchar = 1,
|
|
kushort = 2,
|
|
kshort = 3,
|
|
kuint = 4,
|
|
kint = 5,
|
|
kfloat = 6,
|
|
kdouble = 7,
|
|
kulong = 8,
|
|
klong = 9,
|
|
|
|
//This goes last
|
|
kTypeCount
|
|
}Type;
|
|
|
|
extern RoundingMode set_round( RoundingMode r, Type outType );
|
|
extern RoundingMode get_round( void );
|
|
extern void *FlushToZero( void );
|
|
extern void UnFlushToZero( void *p);
|
|
|
|
|
|
|
|
#endif /* __ROUNDING_MODE_H__ */
|