Files
OpenCL-CTS/test_conformance/SVM/unified_svm_fixture.h
Ben Ashbaugh b63ef2d8f6 add tests for unified SVM corner cases (#2436)
This PR adds tests for a number of interesting unified SVM corner cases.

Not all of these may be valid tests! If we decide that some of these
tests are invalid, I will remove them.

Added tests include:

* Calling clSVMAllocWithPropertiesKHR to allocate zero bytes for each
unified SVM type.
* Calling clSVMFreeWithPropertiesKHR to free a NULL pointer.
* Calling clEnqueueSVMFree to asynchronously free an empty set of SVM
pointers.
* Calling clEnqueueSVMFree to asynchronously free a NULL pointer.
* Calling clSetKernelArgSVMPointer to set a NULL pointer kernel
argument.
* Calling clSetKernelArgSVMPointer to set a bogus pointer kernel
argument.
* Calling clSetKernelExecInfo with CL_KERNEL_EXEC_INFO_SVM_PTRS with an
empty set of SVM pointers.
* Calling clSetKernelExecInfo with CL_KERNEL_EXEC_INFO_SVM_PTRS with a
NULL pointer.
* Calling clSetKernelExecInfo with CL_KERNEL_EXEC_INFO_SVM_PTRS with a
bogus pointer.
* Calling clEnqueueSVMMemcpy with a size of zero and a NULL source or
destination pointer.
* Calling clEnqueueSVMMemcpy with a size of zero and a bogus source or
destination pointer.
* Calling clEnqueueSVMMemcpy with a size of zero and a valid source or
destination pointer.
* Calling clEnqueueSVMMemFill with a size of zero and a NULL destination
pointer.
* Calling clEnqueueSVMMemFill with a size of zero and a bogus
destination pointer.
* Calling clEnqueueSVMMemFill with a size of zero and a valid
destination pointer.
* Calling clEnqueueSVMMigrateMem with a size of zero and a NULL pointer.
* Calling clEnqueueSVMMigrateMem with a size of zero and a valid
pointer.
2025-08-05 10:17:00 -07:00

389 lines
13 KiB
C++

//
// Copyright (c) 2025 The Khronos Group Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
#include "common.h"
#include <algorithm>
#include <memory>
static inline void parseSVMAllocProperties(
std::vector<cl_svm_alloc_properties_khr> props, cl_device_id& device,
cl_svm_alloc_access_flags_khr& accessFlags, size_t& alignment)
{
device = nullptr;
accessFlags = 0;
alignment = 0;
if (!props.empty())
{
size_t i = 0;
while (props[i])
{
switch (props[i])
{
case CL_SVM_ALLOC_ASSOCIATED_DEVICE_HANDLE_KHR:
device = reinterpret_cast<cl_device_id>(props[++i]);
break;
case CL_SVM_ALLOC_ACCESS_FLAGS_KHR:
accessFlags =
static_cast<cl_svm_alloc_access_flags_khr>(props[++i]);
break;
case CL_SVM_ALLOC_ALIGNMENT_KHR:
alignment = static_cast<size_t>(props[++i]);
break;
default:
log_error("Unknown SVM property: %X\n",
static_cast<cl_uint>(props[i]));
return;
}
++i;
}
}
}
template <typename T> class USVMWrapper {
public:
USVMWrapper(cl_context context_, cl_device_id device_,
cl_command_queue queue_, cl_uint typeIndex_,
cl_svm_capabilities_khr caps_, size_t deviceMaxAlignment_,
clSVMAllocWithPropertiesKHR_fn clSVMAllocWithPropertiesKHR_,
clSVMFreeWithPropertiesKHR_fn clSVMFreeWithPropertiesKHR_,
clGetSVMPointerInfoKHR_fn clGetSVMPointerInfoKHR_,
clGetSVMSuggestedTypeIndexKHR_fn clGetSVMSuggestedTypeIndexKHR_)
: context(context_), device(device_), queue(queue_),
typeIndex(typeIndex_), caps(caps_),
deviceMaxAlignment(deviceMaxAlignment_),
clSVMAllocWithPropertiesKHR(clSVMAllocWithPropertiesKHR_),
clSVMFreeWithPropertiesKHR(clSVMFreeWithPropertiesKHR_),
clGetSVMPointerInfoKHR(clGetSVMPointerInfoKHR_),
clGetSVMSuggestedTypeIndexKHR(clGetSVMSuggestedTypeIndexKHR_)
{}
~USVMWrapper() { free(); }
cl_int allocate(const size_t count,
const std::vector<cl_svm_alloc_properties_khr> props_ = {})
{
if (data != nullptr)
{
free();
}
if (caps & CL_SVM_CAPABILITY_SYSTEM_ALLOCATED_KHR)
{
if (count == 0)
{
data = nullptr;
}
else
{
// For now, just unconditionally align to the device maximum
data = static_cast<T*>(
align_malloc(count * sizeof(T), deviceMaxAlignment));
test_assert_error_ret(data != nullptr,
"Failed to allocate memory",
CL_OUT_OF_RESOURCES);
}
}
else
{
std::vector<cl_svm_alloc_properties_khr> props = props_;
if (!props.empty())
{
props.pop_back();
}
if (!(caps & CL_SVM_CAPABILITY_DEVICE_UNASSOCIATED_KHR)
&& std::find(props.begin(), props.end(),
CL_SVM_ALLOC_ASSOCIATED_DEVICE_HANDLE_KHR)
== props.end())
{
props.push_back(CL_SVM_ALLOC_ASSOCIATED_DEVICE_HANDLE_KHR);
props.push_back(
reinterpret_cast<cl_svm_alloc_properties_khr>(device));
}
if (!props.empty() || !props_.empty())
{
props.push_back(0);
}
cl_int err;
data = (T*)clSVMAllocWithPropertiesKHR(
context, props.empty() ? nullptr : props.data(), typeIndex,
count * sizeof(T), &err);
test_error(err, "clSVMAllocWithPropertiesKHR failed");
}
return CL_SUCCESS;
}
void reset() { data = nullptr; }
cl_int free()
{
if (data)
{
if (caps & CL_SVM_CAPABILITY_SYSTEM_ALLOCATED_KHR)
{
align_free(data);
}
else
{
cl_int err;
err = clSVMFreeWithPropertiesKHR(context, nullptr, 0, data);
test_error(err, "clSVMFreeWithPropertiesKHR failed");
}
reset();
}
return CL_SUCCESS;
}
cl_int write(const T* source, size_t count, size_t offset = 0)
{
if (data == nullptr)
{
return CL_INVALID_OPERATION;
}
cl_int err;
if (caps & CL_SVM_CAPABILITY_HOST_WRITE_KHR)
{
std::copy(source, source + count, data + offset);
}
else if (caps & CL_SVM_CAPABILITY_HOST_MAP_KHR)
{
err = clEnqueueSVMMap(queue, CL_TRUE, CL_MAP_WRITE, data,
count * sizeof(T), 0, nullptr, nullptr);
test_error(err, "clEnqueueSVMMap failed");
std::copy(source, source + count, data + offset);
err = clEnqueueSVMUnmap(queue, data, 0, nullptr, nullptr);
test_error(err, "clEnqueueSVMUnmap failed");
err = clFinish(queue);
test_error(err, "clFinish failed");
}
else if (caps & CL_SVM_CAPABILITY_DEVICE_WRITE_KHR)
{
err = clEnqueueSVMMemcpy(queue, CL_TRUE, data + offset, source,
count * sizeof(T), 0, nullptr, nullptr);
test_error(err, "clEnqueueSVMMemcpy failed");
}
else
{
log_error("Not sure how to write to SVM type index %u!\n",
typeIndex);
return CL_INVALID_OPERATION;
}
return CL_SUCCESS;
}
cl_int write(const std::vector<T>& source, size_t offset = 0)
{
return write(source.data(), source.size(), offset);
}
cl_int write(T source, size_t offset = 0)
{
return write(&source, 1, offset);
}
cl_int read(T* dst, size_t count, size_t offset = 0)
{
if (data == nullptr)
{
return CL_INVALID_OPERATION;
}
cl_int err;
if (caps & CL_SVM_CAPABILITY_HOST_READ_KHR)
{
std::copy(data + offset, data + offset + count, dst);
}
else if (caps & CL_SVM_CAPABILITY_HOST_MAP_KHR)
{
err = clEnqueueSVMMap(queue, CL_TRUE, CL_MAP_READ, data,
count * sizeof(T), 0, nullptr, nullptr);
test_error(err, "clEnqueueSVMMap failed");
std::copy(data + offset, data + offset + count, dst);
err = clEnqueueSVMUnmap(queue, data, 0, nullptr, nullptr);
test_error(err, "clEnqueueSVMUnmap failed");
err = clFinish(queue);
test_error(err, "clFinish failed");
}
else if (caps & CL_SVM_CAPABILITY_DEVICE_READ_KHR)
{
err = clEnqueueSVMMemcpy(queue, CL_TRUE, dst, data + offset,
count * sizeof(T), 0, nullptr, nullptr);
test_error(err, "clEnqueueSVMMemcpy failed");
}
else
{
log_error("Not sure how to read from SVM type index %u!\n",
typeIndex);
return CL_INVALID_OPERATION;
}
return CL_SUCCESS;
}
cl_int read(std::vector<T>& dst, size_t offset = 0)
{
return read(dst.data(), dst.size(), offset);
}
cl_int read(T& dst, size_t offset = 0) { return read(&dst, 1, offset); }
T* get_ptr() { return data; }
private:
cl_context context = nullptr;
cl_device_id device = nullptr;
cl_command_queue queue = nullptr;
cl_uint typeIndex = 0;
cl_svm_capabilities_khr caps = 0;
size_t deviceMaxAlignment = 0;
clSVMAllocWithPropertiesKHR_fn clSVMAllocWithPropertiesKHR = nullptr;
clSVMFreeWithPropertiesKHR_fn clSVMFreeWithPropertiesKHR = nullptr;
clGetSVMPointerInfoKHR_fn clGetSVMPointerInfoKHR = nullptr;
clGetSVMSuggestedTypeIndexKHR_fn clGetSVMSuggestedTypeIndexKHR = nullptr;
T* data = nullptr;
};
struct UnifiedSVMBase
{
UnifiedSVMBase(cl_context context_, cl_device_id device_,
cl_command_queue queue_, int num_elements_)
: d(gRandomSeed), context(context_), device(device_), queue(queue_),
num_elements(num_elements_)
{}
virtual cl_int setup()
{
cl_int err;
cl_platform_id platform{};
err = clGetDeviceInfo(device, CL_DEVICE_PLATFORM,
sizeof(cl_platform_id), &platform, nullptr);
test_error(err, "clGetDeviceInfo failed for CL_DEVICE_PLATFORM");
size_t sz{};
err = clGetPlatformInfo(platform, CL_PLATFORM_SVM_TYPE_CAPABILITIES_KHR,
0, nullptr, &sz);
test_error(err,
"clGetPlatformInfo failed for "
"CL_PLATFORM_SVM_TYPE_CAPABILITIES_KHR size");
platformUSVMCaps.resize(sz / sizeof(cl_svm_capabilities_khr));
err = clGetPlatformInfo(platform, CL_PLATFORM_SVM_TYPE_CAPABILITIES_KHR,
sz, platformUSVMCaps.data(), nullptr);
test_error(err,
"clGetPlatformInfo failed for "
"CL_PLATFORM_SVM_TYPE_CAPABILITIES_KHR data");
err = clGetDeviceInfo(device, CL_DEVICE_SVM_TYPE_CAPABILITIES_KHR, 0,
nullptr, &sz);
test_error(
err,
"clGetDeviceInfo failed for CL_DEVICE_SVM_CAPABILITIES_KHR size");
deviceUSVMCaps.resize(sz / sizeof(cl_svm_capabilities_khr));
err = clGetDeviceInfo(device, CL_DEVICE_SVM_TYPE_CAPABILITIES_KHR, sz,
deviceUSVMCaps.data(), nullptr);
test_error(
err,
"clGetDeviceInfo failed for CL_DEVICE_SVM_CAPABILITIES_KHR data");
clSVMAllocWithPropertiesKHR = (clSVMAllocWithPropertiesKHR_fn)
clGetExtensionFunctionAddressForPlatform(
platform, "clSVMAllocWithPropertiesKHR");
test_assert_error_ret(clSVMAllocWithPropertiesKHR != nullptr,
"clSVMAllocWithPropertiesKHR not found",
CL_INVALID_OPERATION);
clSVMFreeWithPropertiesKHR = (clSVMFreeWithPropertiesKHR_fn)
clGetExtensionFunctionAddressForPlatform(
platform, "clSVMFreeWithPropertiesKHR");
test_assert_error_ret(clSVMFreeWithPropertiesKHR != nullptr,
"clSVMFreeWithPropertiesKHR not found",
CL_INVALID_OPERATION);
clGetSVMPointerInfoKHR =
(clGetSVMPointerInfoKHR_fn)clGetExtensionFunctionAddressForPlatform(
platform, "clGetSVMPointerInfoKHR");
test_assert_error_ret(clGetSVMPointerInfoKHR != nullptr,
"clGetSVMPointerInfoKHR not found",
CL_INVALID_OPERATION);
clGetSVMSuggestedTypeIndexKHR = (clGetSVMSuggestedTypeIndexKHR_fn)
clGetExtensionFunctionAddressForPlatform(
platform, "clGetSVMSuggestedTypeIndexKHR");
test_assert_error_ret(clGetSVMSuggestedTypeIndexKHR != nullptr,
"clGetSVMSuggestedTypeIndexKHR not found",
CL_INVALID_OPERATION);
// The maximum supported alignment is equal to the size of the largest
// data type supported by the device
if (gHasLong || is_extension_available(device, "cl_khr_fp64"))
{
deviceMaxAlignment = 16 * sizeof(cl_long);
}
else
{
deviceMaxAlignment = 16 * sizeof(cl_int);
}
return CL_SUCCESS;
}
virtual cl_int run() = 0;
template <typename T>
std::unique_ptr<USVMWrapper<T>> get_usvm_wrapper(cl_uint typeIndex)
{
return std::unique_ptr<USVMWrapper<T>>(new USVMWrapper<T>(
context, device, queue, typeIndex, deviceUSVMCaps[typeIndex],
deviceMaxAlignment, clSVMAllocWithPropertiesKHR,
clSVMFreeWithPropertiesKHR, clGetSVMPointerInfoKHR,
clGetSVMSuggestedTypeIndexKHR));
}
MTdataHolder d;
cl_context context = nullptr;
cl_device_id device = nullptr;
cl_command_queue queue = nullptr;
int num_elements = 0;
std::vector<cl_svm_capabilities_khr> platformUSVMCaps;
std::vector<cl_svm_capabilities_khr> deviceUSVMCaps;
size_t deviceMaxAlignment = 0;
clSVMAllocWithPropertiesKHR_fn clSVMAllocWithPropertiesKHR = nullptr;
clSVMFreeWithPropertiesKHR_fn clSVMFreeWithPropertiesKHR = nullptr;
clGetSVMPointerInfoKHR_fn clGetSVMPointerInfoKHR = nullptr;
clGetSVMSuggestedTypeIndexKHR_fn clGetSVMSuggestedTypeIndexKHR = nullptr;
};