* rewrite test_select to run in a few seconds.
* removing the threading; reverting to the original method.
* Merge from Master, remove all suggested changes and start with a simple change report on each change's cost savings:
BEFORE:
real 47m8.497s
user 48m8.860s
sys 0m14.952s
AFTER:
real 17m53.383s
user 18m53.342s
sys 0m13.297s
initSrcBuffer generates the same random noise every iteration through the loop. There is no change to the arguments, and the host data itself doesn't need to get rewritten. Profiling realizes a 2 times speed accel from simply relying upon the buffer to remain randomized at the next loop iteration.
* BEFORE:
real 17m53.383s
user 18m53.342s
sys 0m13.297s
AFTER:
real 12m26.035s
user 13m15.505s
sys 0m15.414s
rearrange a few things in the loops to allow for vectorized / interleaved loop traversal. NB: not all loops are vectorizable obviously; but this addresses the worst offenders. Also note, to enable compiler to generate vectorized and interleaved loop traversal build with -o3.
* address the CI format requirements.
* address the CI format requirements.
* address the CI format requirements.
* Printing of a `size_t` requires the `%z` specifier.
* Printing of `cl_long`/`cl_ulong` is now done using the `PRI*64`
macros to ensure portability across 32 and 64-bit builds.
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
* Added cl_half support for test_select (issue #142, select)
* Added corrections due to code review + performance optimization + replaced C object with wrappers
* minor fix
* Corrected use of user event
* Removed unnecessary user event
* select: using clEnqueueReadBuffer rather than clEnqueueMapBuffer
* Update code to be compatible with clang-format
* update code again to be compatible with clang-format
* update code again to comply with clang-format
* updata code again to be compatible with clang-format
The clang-format tool is so weird, it's not even consistent between runs...
Simplify code by avoiding manual resource management.
This fixes use of an uninitialized `d` in the `free_mtdata` call, in
the case a `goto exit` was executed before initializing `d`.
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
Remove unused variables throughout the code base and enable the
`-Wunused-variable` warning flag globally to prevent new unused
variable issues being introduced in the future.
This is mostly a non-functional change, with one exception:
- In `test_conformance/api/test_kernel_arg_info.cpp`, an error check
of the clGetDeviceInfo return value was added.
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
When verification of the computed result fails, the test would still
report as "passed". This is because `s_test_fail` is only written to
and never read.
Fix the immediate issue by returning a failure value and incrementing
`gFailCount` if any error was detected. The error handling can be
improved further, but I'm leaving that out of the scope of this fix.
Fixes https://github.com/KhronosGroup/OpenCL-CTS/issues/1445
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
* Use memcmp for select verification.
If memcmp fails, fall back to looping through the result buffer to find the incorrect result.
* Removed extra prints for check_int.
* Tests requiring image support use runTestHarnessWithCheck
Removing special case for images in runTestHarness.
Fixes#710
* Remove imageSupportRequired argument
Tests which require image support now specify this while
calling runTestHarnessWithCheck.
Fixes#710
Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
The local parsing of arguments in test_select.c throws away any unknown
arguments. Pass these to parseCustomParam() before the local argument
parsing, so that the offline compilation options work as expected.
Fixes#327.
Signed-off-by: Stuart Brady <stuart.brady@arm.com>
The maintenance of the conformance tests is moving to Github.
This commit contains all the changes that have been done in
Gitlab since the first public release of the conformance tests.
Signed-off-by: Kevin Petit kevin.petit@arm.com
