From fffd4f24742529c7f83c4d1efdda1b04f9be9056 Mon Sep 17 00:00:00 2001 From: Sreelakshmi Haridas Maruthur Date: Mon, 21 Sep 2020 10:51:54 -0600 Subject: [PATCH] compiler: Modify the IL check code to check for an empty string (#964) The called function (get_device_info_string) subtracts 1 from length before returning it. Hence, to check for an empty string (that the spec requires the implementation to return when CL_DEVICE_IL_VERSION is not supported) the check should be modified to check for empty and not length == 1 --- test_conformance/compiler/test_unload_platform_compiler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_conformance/compiler/test_unload_platform_compiler.cpp b/test_conformance/compiler/test_unload_platform_compiler.cpp index e55bd93f..bb3ee95b 100644 --- a/test_conformance/compiler/test_unload_platform_compiler.cpp +++ b/test_conformance/compiler/test_unload_platform_compiler.cpp @@ -265,7 +265,7 @@ public: Version version = get_device_cl_version(device); std::string sILVersion = get_device_il_version_string(device); if ((version >= Version(2, 1) && version < Version(3, 0)) - || (version >= Version(3, 0) && sILVersion.length() != 1)) + || (version >= Version(3, 0) && !sILVersion.empty())) { m_CreateProgramWithIL = clCreateProgramWithIL; m_enabled = true;