ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 16:29:03 +00:00
Code Packages Projects Releases Wiki Activity

events: Remove unused BufferAction::Setup parameter (#1586)

Browse Source 
`BufferAction::Setup` has an additional parameter `allocate` which
hides the virtual function `Action::Setup`.  The additional parameter
was unused anyway, so remove it.

Fixes a -Woverloaded-virtual warning.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2022-12-13 17:53:11 +00:00
committed by GitHub
parent f48dd72da8
commit fb949f9256
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test_conformance/events/action_classes.cpp
View File

@@ -189,7 +189,7 @@ cl_int NDRangeKernelAction::Execute(cl_command_queue queue, cl_uint numWaits,
#pragma mark -------------------- Buffer Sub-Classes ------------------------- #pragma mark -------------------- Buffer Sub-Classes -------------------------
cl_int BufferAction::Setup(cl_device_id device, cl_context context, cl_int BufferAction::Setup(cl_device_id device, cl_context context,
cl_command_queue queue, bool allocate) cl_command_queue queue)
{ {
cl_int error; cl_int error;
cl_ulong maxAllocSize; cl_ulong maxAllocSize;
@@ -227,7 +227,7 @@ cl_int BufferAction::Setup(cl_device_id device, cl_context context,
cl_int ReadBufferAction::Setup(cl_device_id device, cl_context context, cl_int ReadBufferAction::Setup(cl_device_id device, cl_context context,
cl_command_queue queue) cl_command_queue queue)
{ {
return BufferAction::Setup(device, context, queue, true); return BufferAction::Setup(device, context, queue);
} }
cl_int ReadBufferAction::Execute(cl_command_queue queue, cl_uint numWaits, cl_int ReadBufferAction::Execute(cl_command_queue queue, cl_uint numWaits,
@@ -243,7 +243,7 @@ cl_int ReadBufferAction::Execute(cl_command_queue queue, cl_uint numWaits,
cl_int WriteBufferAction::Setup(cl_device_id device, cl_context context, cl_int WriteBufferAction::Setup(cl_device_id device, cl_context context,
cl_command_queue queue) cl_command_queue queue)
{ {
return BufferAction::Setup(device, context, queue, true); return BufferAction::Setup(device, context, queue);
} }
cl_int WriteBufferAction::Execute(cl_command_queue queue, cl_uint numWaits, cl_int WriteBufferAction::Execute(cl_command_queue queue, cl_uint numWaits,
@@ -265,7 +265,7 @@ MapBufferAction::~MapBufferAction()
cl_int MapBufferAction::Setup(cl_device_id device, cl_context context, cl_int MapBufferAction::Setup(cl_device_id device, cl_context context,
cl_command_queue queue) cl_command_queue queue)
{ {
return BufferAction::Setup(device, context, queue, false); return BufferAction::Setup(device, context, queue);
} }
cl_int MapBufferAction::Execute(cl_command_queue queue, cl_uint numWaits, cl_int MapBufferAction::Execute(cl_command_queue queue, cl_uint numWaits,
@@ -283,7 +283,7 @@ cl_int MapBufferAction::Execute(cl_command_queue queue, cl_uint numWaits,
cl_int UnmapBufferAction::Setup(cl_device_id device, cl_context context, cl_int UnmapBufferAction::Setup(cl_device_id device, cl_context context,
cl_command_queue queue) cl_command_queue queue)
{ {
cl_int error = BufferAction::Setup(device, context, queue, false); cl_int error = BufferAction::Setup(device, context, queue);
if (error != CL_SUCCESS) return error; if (error != CL_SUCCESS) return error;
mMappedPtr = clEnqueueMapBuffer(queue, mBuffer, CL_TRUE, CL_MAP_READ, 0, mMappedPtr = clEnqueueMapBuffer(queue, mBuffer, CL_TRUE, CL_MAP_READ, 0,

2
test_conformance/events/action_classes.h
View File

@@ -72,7 +72,7 @@ public:
virtual ~BufferAction() { free(mOutBuffer); } virtual ~BufferAction() { free(mOutBuffer); }
virtual cl_int Setup(cl_device_id device, cl_context context, virtual cl_int Setup(cl_device_id device, cl_context context,
cl_command_queue queue, bool allocate); cl_command_queue queue);
}; };
class ReadBufferAction : public BufferAction { class ReadBufferAction : public BufferAction {