ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 16:29:03 +00:00
Code Packages Projects Releases Wiki Activity

spir: Fix -Wcatch-value warnings (#1565)

Browse Source 
`std::exception` and `std::runtime_error` are polymorphic types and as
such they shouldn't be passed by value.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2022-11-24 11:43:51 +00:00
committed by GitHub
parent c6bb15c289
commit e9d2abf705
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test_conformance/spir/main.cpp
View File

@@ -6253,7 +6253,7 @@ static bool test_image_enumeration(cl_context context, cl_command_queue queue,
(FailE)(it.toString(), kernelName); (FailE)(it.toString(), kernelName);
std::cout << "enum_" << it.toString() << " FAILED" << std::endl; std::cout << "enum_" << it.toString() << " FAILED" << std::endl;
} }
} catch(std::exception e) } catch (const std::exception &e)
{ {
(FailE)(it.toString(), kernelName); (FailE)(it.toString(), kernelName);
print_error(1, e.what()); print_error(1, e.what());
@@ -6356,7 +6356,7 @@ static bool test_image_enumeration_3d(cl_context context, cl_command_queue queue
(FailE)(it.toString(), kernelName); (FailE)(it.toString(), kernelName);
std::cout << "enum_" << it.toString() << " FAILED" << std::endl; std::cout << "enum_" << it.toString() << " FAILED" << std::endl;
} }
} catch(std::exception e) } catch (const std::exception &e)
{ {
(FailE)(it.toString(), kernelName); (FailE)(it.toString(), kernelName);
print_error(1, e.what()); print_error(1, e.what());
@@ -6521,7 +6521,7 @@ test_kernel_attributes(cl_device_id device, cl_uint width, const char *folder)
} }
(SuccE)(test_name, ""); (SuccE)(test_name, "");
log_info("kernel_attributes passed.\n"); log_info("kernel_attributes passed.\n");
} catch(std::exception e) } catch (const std::exception &e)
{ {
(FailE)(test_name, ""); (FailE)(test_name, "");
log_info("kernel_attributes FAILED\n"); log_info("kernel_attributes FAILED\n");
@@ -6587,7 +6587,7 @@ static bool test_binary_type(cl_device_id device, cl_uint width, const char *fol
} }
(SuccE)(test_name, ""); (SuccE)(test_name, "");
log_info("binary_type passed.\n"); log_info("binary_type passed.\n");
} catch(std::exception e) } catch (const std::exception &e)
{ {
(FailE)(test_name, ""); (FailE)(test_name, "");
log_info("binary_type FAILED\n"); log_info("binary_type FAILED\n");

3
test_conformance/spir/run_build_test.cpp
View File

@@ -462,8 +462,7 @@ bool TestRunner::runBuildTest(cl_device_id device, const char *folder,
log_info("kernel '%s' failed.\n", kernel_name.c_str()); log_info("kernel '%s' failed.\n", kernel_name.c_str());
(*m_failureHandler)(test_name, kernel_name); (*m_failureHandler)(test_name, kernel_name);
} }
} } catch (const std::runtime_error& err)
catch (std::runtime_error err)
{ {
++failures; ++failures;
log_info("kernel '%s' failed: %s\n", kernel_name.c_str(), err.what()); log_info("kernel '%s' failed: %s\n", kernel_name.c_str(), err.what());