ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-23 15:39:03 +00:00
Code Packages Projects Releases Wiki Activity

atomics: Remove unused variable in atomic_add_index_bin (#1709)

Browse Source 
Remove a variable that was set when an OpenCL API call failed, but
never read again.  Instead, return immediately upon failure.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2023-05-11 14:12:09 +01:00
committed by GitHub
parent 8272c83c6f
commit d223e46f20
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test_conformance/atomics/test_indexed_cases.cpp
View File

@@ -201,7 +201,6 @@ int add_index_bin_test(size_t *global_threads, cl_command_queue queue,
int number_of_bins = number_of_items / divisor; int number_of_bins = number_of_items / divisor;
int max_counts_per_bin = divisor * 2; int max_counts_per_bin = divisor * 2;
int fail = 0;
int err; int err;
clProgramWrapper program; clProgramWrapper program;
@@ -345,7 +344,6 @@ int add_index_bin_test(size_t *global_threads, cl_command_queue queue,
{ {
log_error("add_index_bin_test FAILED to set kernel arguments: %d\n", log_error("add_index_bin_test FAILED to set kernel arguments: %d\n",
err); err);
fail = 1;
return -1; return -1;
} }
@@ -354,7 +352,7 @@ int add_index_bin_test(size_t *global_threads, cl_command_queue queue,
if (err) if (err)
{ {
log_error("add_index_bin_test FAILED to execute kernel: %d\n", err); log_error("add_index_bin_test FAILED to execute kernel: %d\n", err);
fail = 1; return -1;
} }
cl_int *final_bin_assignments = cl_int *final_bin_assignments =
@@ -372,7 +370,7 @@ int add_index_bin_test(size_t *global_threads, cl_command_queue queue,
if (err) if (err)
{ {
log_error("add_index_bin_test FAILED to read back bins: %d\n", err); log_error("add_index_bin_test FAILED to read back bins: %d\n", err);
fail = 1; return -1;
} }
cl_int *final_bin_counts = cl_int *final_bin_counts =
@@ -390,7 +388,7 @@ int add_index_bin_test(size_t *global_threads, cl_command_queue queue,
{ {
log_error("add_index_bin_test FAILED to read back bin_counters: %d\n", log_error("add_index_bin_test FAILED to read back bin_counters: %d\n",
err); err);
fail = 1; return -1;
} }
// Verification. // Verification.