From b9301d1ae8a3ce79cd8137e17a88bade22604e38 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Tue, 18 Mar 2025 17:02:31 +0100 Subject: [PATCH] basic: fix -Wformat-security warnings (#2284) Fix warnings such as: test_vloadstore.cpp:330:49: error: format string is not a string literal (potentially insecure) There were no security issues here as the format string arguments do not contain any conversion specifiers and are never written to. Make that latter fact explicit to avoid the warnings. Signed-off-by: Sven van Haastregt --- test_conformance/basic/test_vloadstore.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test_conformance/basic/test_vloadstore.cpp b/test_conformance/basic/test_vloadstore.cpp index d34ecbf9..e076c081 100644 --- a/test_conformance/basic/test_vloadstore.cpp +++ b/test_conformance/basic/test_vloadstore.cpp @@ -46,10 +46,10 @@ char load_str[128] = { 0 }; extern cl_half_rounding_mode halfRoundingMode; // clang-format off -static const char *store_pattern= "results[ tid ] = tmp;\n"; -static const char *store_patternV3 = "results[3*tid] = tmp.s0; results[3*tid+1] = tmp.s1; results[3*tid+2] = tmp.s2;\n"; -static const char *load_pattern = "sSharedStorage[ i ] = src[ i ];\n"; -static const char *load_patternV3 = "sSharedStorage[3*i] = src[ 3*i]; sSharedStorage[3*i+1] = src[3*i+1]; sSharedStorage[3*i+2] = src[3*i+2];\n"; +static const char *const store_pattern= "results[ tid ] = tmp;\n"; +static const char *const store_patternV3 = "results[3*tid] = tmp.s0; results[3*tid+1] = tmp.s1; results[3*tid+2] = tmp.s2;\n"; +static const char *const load_pattern = "sSharedStorage[ i ] = src[ i ];\n"; +static const char *const load_patternV3 = "sSharedStorage[3*i] = src[ 3*i]; sSharedStorage[3*i+1] = src[3*i+1]; sSharedStorage[3*i+2] = src[3*i+2];\n"; static const char *kernel_pattern[] = { pragma_str, "#define STYPE %s\n"