From abd556f7a2ad98d1b08b145b6fd5c5e813fda125 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Wed, 31 May 2023 10:02:54 +0100 Subject: [PATCH] relationals: add missing virtual destructor (#1739) `RelationalsFPTest` contains a vector of `RelTestBase` pointers to `RelTestParams` instances, so the base class destructor should be virtual to avoid undefined behaviour. Fixes https://github.com/KhronosGroup/OpenCL-CTS/issues/1731 Signed-off-by: Sven van Haastregt --- test_conformance/relationals/test_comparisons_fp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/test_conformance/relationals/test_comparisons_fp.h b/test_conformance/relationals/test_comparisons_fp.h index 7faca1c5..66c62c2d 100644 --- a/test_conformance/relationals/test_comparisons_fp.h +++ b/test_conformance/relationals/test_comparisons_fp.h @@ -32,6 +32,7 @@ template using VerifyFunc = bool (*)(const T &, const T &); struct RelTestBase { explicit RelTestBase(const ExplicitTypes &dt): dataType(dt) {} + virtual ~RelTestBase() = default; ExplicitTypes dataType; };