ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 08:19:02 +00:00
Code Packages Projects Releases Wiki Activity

Report unsupported extended subgroup tests as skipped rather than passed (#1301)

Browse Source 
* Report unsupported extended subgroup tests as skipped rather than passed

Also don't check the presence of extensions for each sub-test.

Signed-off-by: Kévin Petit <kpet@free.fr>

* address review comments
This commit is contained in:
Kévin Petit
2021-09-30 13:33:18 +01:00
committed by GitHub
parent 2b770c4f34
commit 903f1bf65d
8 changed files with 52 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test_conformance/subgroups/subhelpers.h
View File

@@ -33,10 +33,9 @@ extern cl_half_rounding_mode g_rounding_mode;
struct WorkGroupParams
{
WorkGroupParams(size_t gws, size_t lws,
const std::vector<std::string> &req_ext = {},
const std::vector<uint32_t> &all_wim = {})
: global_workgroup_size(gws), local_workgroup_size(lws),
required_extensions(req_ext), all_work_item_masks(all_wim)
all_work_item_masks(all_wim)
{
subgroup_size = 0;
work_items_mask = 0;
@@ -49,7 +48,6 @@ struct WorkGroupParams
uint32_t work_items_mask;
int dynsc;
bool use_core_subgroups;
std::vector<std::string> required_extensions;
std::vector<uint32_t> all_work_item_masks;
};
@@ -1297,19 +1295,6 @@ template <typename Ty, typename Fns, size_t TSIZE = 0> struct test
}
}
for (std::string extension : test_params.required_extensions)
{
if (!is_extension_available(device, extension.c_str()))
{
log_info("The extension %s not supported on this device. SKIP "
"testing - kernel %s data type %s\n",
extension.c_str(), kname, TypeManager<Ty>::name());
return TEST_PASS;
}
kernel_sstr << "#pragma OPENCL EXTENSION " + extension
+ ": enable\n";
}
error = clGetDeviceInfo(device, CL_DEVICE_PLATFORM, sizeof(platform),
(void *)&platform, NULL);
test_error(error, "clGetDeviceInfo failed for CL_DEVICE_PLATFORM");