ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update List of Skipped Tests in Offline Mode (#840)

Browse Source 
* Fix Tests Assuming Online Compilation in Offline MOde

* Update the list of tests to skip in offline mode. These tests need
to be skipped for offline-binary mode since they make API calls that
rely on a compiler being present in the runtime.

- [x] Skip `get_kernel_arg_info_compatibility`  since it makes calls to
`clBuildProgram`. (these tests cannot be run in offline mode since:
*Kernel argument information is only available if the program object
associated with kernel is created with `clCreateProgramWithSource` and
the program executable was built with the `-cl-kernel-arg-info` option
specified in options argument to `clBuildProgram` or `clCompileProgram`
.*)

- [x] Skip `compiler` tests that make calls to `clCompileProgram`. These
tests could still be run in offline spirv mode if there is a compiler in
the driver.

- [x] Use offline compilation path in `contractions` in the case that
CTS is run in offline.

* Avoid shadowing `error` variable

Co-authored-by: Ewan Crawford <ewan@codeplay.com>
This commit is contained in:
Jack Frankland
2020-07-23 06:52:38 +01:00
committed by GitHub
parent a34bae7abc
commit 8e9ab19a3b
2 changed files with 77 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
test_conformance/contractions/contractions.cpp
View File

@@ -576,56 +576,39 @@ test_status InitCL( cl_device_id device )
"}\n"
"\n" };
for( i = 0; i < sizeof( sizeNames ) / sizeof( sizeNames[0] ); i++ )
for (i = 0; i < sizeof(sizeNames) / sizeof(sizeNames[0]); i++)
{
size_t strCount = sizeof( kernels ) / sizeof( kernels[0] );
size_t strCount = sizeof(kernels) / sizeof(kernels[0]);
kernels[0] = "";
for( j = 2; j < strCount; j += 2 )
kernels[j] = sizeNames[i];
gProgram[i] = clCreateProgramWithSource(gContext, strCount, kernels, NULL, &error);
if( NULL == gProgram[i] )
for (j = 2; j < strCount; j += 2) kernels[j] = sizeNames[i];
error = create_single_kernel_helper(gContext, &gProgram[i], nullptr,
strCount, kernels, nullptr);
if (CL_SUCCESS != error || nullptr == gProgram[i])
{
vlog_error( "clCreateProgramWithSource failed\n" );
return TEST_FAIL;
}
if(( error = clBuildProgram(gProgram[i], 1, &device, NULL, NULL, NULL) ))
{
vlog_error( "clBuildProgramExecutable failed\n" );
char build_log[2048] = "";
clGetProgramBuildInfo(gProgram[i], device, CL_PROGRAM_BUILD_LOG, sizeof(build_log), build_log, NULL);
vlog_error( "Log:\n%s\n", build_log );
log_error("Error: Unable to create test program! (%s) (in %s:%d)\n",
IGetErrorString(error), __FILE__, __LINE__);
return TEST_FAIL;
}
}
if( gHasDouble )
if (gHasDouble)
{
kernels[0] = "#pragma OPENCL EXTENSION cl_khr_fp64 : enable\n";
for( i = 0; i < sizeof( sizeNames_double ) / sizeof( sizeNames_double[0] ); i++ )
for (i = 0; i < sizeof(sizeNames_double) / sizeof(sizeNames_double[0]);
i++)
{
size_t strCount = sizeof( kernels ) / sizeof( kernels[0] );
size_t strCount = sizeof(kernels) / sizeof(kernels[0]);
for( j = 2; j < strCount; j += 2 )
kernels[j] = sizeNames_double[i];
gProgram_double[i] = clCreateProgramWithSource(gContext, strCount, kernels, NULL, &error);
if( NULL == gProgram_double[i] )
for (j = 2; j < strCount; j += 2) kernels[j] = sizeNames_double[i];
error = create_single_kernel_helper(gContext, &gProgram_double[i],
nullptr, strCount, kernels,
nullptr);
if (CL_SUCCESS != error || nullptr == gProgram_double[i])
{
vlog_error( "clCreateProgramWithSource failed\n" );
return TEST_FAIL;
}
if(( error = clBuildProgram(gProgram_double[i], 1, &device, NULL, NULL, NULL) ))
{
vlog_error( "clBuildProgramExecutable failed\n" );
char build_log[2048] = "";
clGetProgramBuildInfo(gProgram_double[i], device, CL_PROGRAM_BUILD_LOG, sizeof(build_log), build_log, NULL);
vlog_error( "Log:\n%s\n", build_log );
log_error(
"Error: Unable to create test program! (%s) (in %s:%d)\n",
IGetErrorString(error), __FILE__, __LINE__);
return TEST_FAIL;
}
}