ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Context Leak in api:clone_kernel (#1090)

Browse Source 
In this test we repeated call create_single_kernel_helper
to create different kernels but reuse the same clProgramWrapper.
create_single_kernel_helper() creates a new program each time it
is called, creating a new reference on the underlying context.
When the test ends, the program is released (as it should when
using the clProgramWrapper), however there are multiple program
objects attached to the context resulting in reference leak errors.

Signed-off-by: Chetankumar Mistry <chetan.mistry@arm.com>
This commit is contained in:
Chetan Mistry
2021-01-04 16:13:06 +00:00
committed by GitHub
parent 1cd9d084d5
commit 85bae70f81
1 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
test_conformance/api/test_clone_kernel.cpp
View File

@@ -113,15 +113,16 @@ int test_image_arg_shallow_clone(cl_device_id deviceID, cl_context context, cl_c
clSamplerWrapper sampler;
img_format.image_channel_order = CL_RGBA;
img_format.image_channel_data_type = CL_UNSIGNED_INT8;
cl_image_desc imageDesc;
memset(&imageDesc, 0x0, sizeof(cl_image_desc));
cl_image_desc imageDesc;
memset(&imageDesc, 0x0, sizeof(cl_image_desc));
imageDesc.image_type = CL_MEM_OBJECT_IMAGE2D;
imageDesc.image_width = 512;
imageDesc.image_height = 512;
cl_uint color[4] = {1,3,5,7};
clProgramWrapper program;
clProgramWrapper program_read;
clProgramWrapper program_write;
clKernelWrapper kernel_read;
clKernelWrapper kernel_write;
clKernelWrapper kernel_cloned;
@@ -129,12 +130,16 @@ int test_image_arg_shallow_clone(cl_device_id deviceID, cl_context context, cl_c
clMemWrapper img;
if( create_single_kernel_helper( context, &program, &kernel_read, 1, clone_kernel_test_img, "img_read_kernel" ) != 0 )
if (create_single_kernel_helper(context, &program_read, &kernel_read, 1,
clone_kernel_test_img, "img_read_kernel")
!= 0)
{
return -1;
}
if( create_single_kernel_helper( context, &program, &kernel_write, 1, clone_kernel_test_img, "img_write_kernel" ) != 0 )
if (create_single_kernel_helper(context, &program_write, &kernel_write, 1,
clone_kernel_test_img, "img_write_kernel")
!= 0)
{
return -1;
}
@@ -241,6 +246,8 @@ int test_clone_kernel(cl_device_id deviceID, cl_context context, cl_command_queu
{
int error;
clProgramWrapper program;
clProgramWrapper program_buf_read;
clProgramWrapper program_buf_write;
clKernelWrapper kernel;
clKernelWrapper kernel_pipe_read;
clKernelWrapper kernel_buf_read;
@@ -272,12 +279,18 @@ int test_clone_kernel(cl_device_id deviceID, cl_context context, cl_command_queu
return -1;
}
if( create_single_kernel_helper( context, &program, &kernel_buf_read, 1, clone_kernel_test_kernel, "buf_read_kernel" ) != 0 )
if (create_single_kernel_helper(context, &program_buf_read,
&kernel_buf_read, 1,
clone_kernel_test_kernel, "buf_read_kernel")
!= 0)
{
return -1;
}
if( create_single_kernel_helper( context, &program, &kernel_buf_write, 1, clone_kernel_test_kernel, "buf_write_kernel" ) != 0 )
if (create_single_kernel_helper(
context, &program_buf_write, &kernel_buf_write, 1,
clone_kernel_test_kernel, "buf_write_kernel")
!= 0)
{
return -1;
}