From 7d3db1bd0724733e41c9343a8772541f553f8063 Mon Sep 17 00:00:00 2001 From: Romaric Jodin <89833130+rjodinchr@users.noreply.github.com> Date: Tue, 16 Jan 2024 18:52:08 +0100 Subject: [PATCH] fix return code when readwrite image is not supported (#1873) This function (do_test) starts by testing write and read individually. Both of them can have errors. When readwrite image is not supported, the function returns TEST_SKIPPED_ITSELF potentially masking errors leading to the test returning EXIT_SUCCESS even with errors along the way. --- test_conformance/images/kernel_read_write/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_conformance/images/kernel_read_write/main.cpp b/test_conformance/images/kernel_read_write/main.cpp index 0a93a974..debbdf18 100644 --- a/test_conformance/images/kernel_read_write/main.cpp +++ b/test_conformance/images/kernel_read_write/main.cpp @@ -202,7 +202,7 @@ static int doTest( cl_device_id device, cl_context context, cl_command_queue que if ((testTypesToRun & kReadWriteTests) && checkForReadWriteImageSupport(device)) { - return TEST_SKIPPED_ITSELF; + return ret; } if( ( testTypesToRun & kReadWriteTests ) && !gTestMipmaps )