ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-26 08:49:02 +00:00
Code Packages Projects Releases Wiki Activity

[NFC] relationals: Tidy up get_order_string (#1591)

Browse Source 
Remove a misleading comment at the end.  Improve comments in general,
and use `true`/`false` for `bool`s.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2022-12-08 12:08:56 +00:00
committed by GitHub
parent 1c2c4581bd
commit 73c6955068
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test_conformance/relationals/test_shuffles.cpp
View File

@@ -201,14 +201,13 @@ const char *get_order_string( ShuffleOrder &order, size_t vecSize, cl_uint lengt
size_t j, idx; size_t j, idx;
// Assume we don't have to use numbers // Assume we don't have to use numbered indices (.s0123...).
byNumber = 0; byNumber = false;
// Check to see // Check if any index is beyond xyzw, which requires to use numbers.
for( j = 0; j < lengthToUse; j++ ) for( j = 0; j < lengthToUse; j++ )
{ {
if (order[j] > 3) { if (order[j] > 3) {
// An index is > xyzw so we need to use numbers byNumber = true;
byNumber = 1;
break; break;
} }
} }
@@ -220,7 +219,7 @@ const char *get_order_string( ShuffleOrder &order, size_t vecSize, cl_uint lengt
if (byNumber) if (byNumber)
{ {
idx = 0; idx = 0;
// Randomly chose upper and lower case S // Randomly chose upper and lower case S.
orderString[ idx++ ] = random_in_range(0, 1, d) ? 's' : 'S'; orderString[ idx++ ] = random_in_range(0, 1, d) ? 's' : 'S';
for( j = 0; j < vecSize && j < lengthToUse; j++ ) { for( j = 0; j < vecSize && j < lengthToUse; j++ ) {
// Randomly choose upper and lower case. // Randomly choose upper and lower case.
@@ -230,8 +229,8 @@ const char *get_order_string( ShuffleOrder &order, size_t vecSize, cl_uint lengt
} }
else else
{ {
// Use xyzw.
for( j = 0; j < vecSize && j < lengthToUse; j++ ) { for( j = 0; j < vecSize && j < lengthToUse; j++ ) {
// Randomly choose upper and lower case.
orderString[ j ] = names2[ (int)order[ j ] ]; orderString[ j ] = names2[ (int)order[ j ] ];
} }
orderString[ j ] = 0; orderString[ j ] = 0;