From 6659a1b6b8a4a989fe5d28ebd012c15f4e6872cf Mon Sep 17 00:00:00 2001 From: Ben Ashbaugh Date: Tue, 4 Oct 2022 09:02:25 -0700 Subject: [PATCH] remove implicit conversion to pointer to fix 32-bit compile (#1488) * remove implicit conversion to pointer to fix 32-bit compile * fix formatting --- .../vulkan_interop_common/vulkan_list_map.hpp | 4 ++-- .../vulkan/vulkan_interop_common/vulkan_utility.cpp | 2 +- .../vulkan/vulkan_interop_common/vulkan_wrapper.cpp | 13 +++++++------ 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/test_conformance/vulkan/vulkan_interop_common/vulkan_list_map.hpp b/test_conformance/vulkan/vulkan_interop_common/vulkan_list_map.hpp index 10a7b221..52206779 100644 --- a/test_conformance/vulkan/vulkan_interop_common/vulkan_list_map.hpp +++ b/test_conformance/vulkan/vulkan_interop_common/vulkan_list_map.hpp @@ -37,7 +37,7 @@ public: virtual size_t size() const; virtual const VulkanWrapper &operator[](size_t idx) const; virtual VulkanWrapper &operator[](size_t idx); - virtual operator const VulkanNative *() const; + virtual const VulkanNative *operator()() const; }; template class VulkanMap { @@ -340,7 +340,7 @@ VulkanWrapper &VulkanList::operator[](size_t idx) } template -VulkanList::operator const VulkanNative *() const +const VulkanNative *VulkanList::operator()() const { return m_nativeList.data(); } diff --git a/test_conformance/vulkan/vulkan_interop_common/vulkan_utility.cpp b/test_conformance/vulkan/vulkan_interop_common/vulkan_utility.cpp index 4e6118b1..1a313cce 100644 --- a/test_conformance/vulkan/vulkan_interop_common/vulkan_utility.cpp +++ b/test_conformance/vulkan/vulkan_interop_common/vulkan_utility.cpp @@ -183,7 +183,7 @@ bool checkVkSupport() const VulkanInstance &instance = getVulkanInstance(); const VulkanPhysicalDeviceList &physicalDeviceList = instance.getPhysicalDeviceList(); - if (physicalDeviceList == NULL) + if (physicalDeviceList() == NULL) { std::cout << "physicalDeviceList is null, No GPUs found with " "Vulkan support !!!\n"; diff --git a/test_conformance/vulkan/vulkan_interop_common/vulkan_wrapper.cpp b/test_conformance/vulkan/vulkan_interop_common/vulkan_wrapper.cpp index e5d3a271..6209a747 100644 --- a/test_conformance/vulkan/vulkan_interop_common/vulkan_wrapper.cpp +++ b/test_conformance/vulkan/vulkan_interop_common/vulkan_wrapper.cpp @@ -626,12 +626,12 @@ void VulkanQueue::submit(const VulkanSemaphoreList &waitSemaphoreList, vkSubmitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO; vkSubmitInfo.pNext = NULL; vkSubmitInfo.waitSemaphoreCount = (uint32_t)waitSemaphoreList.size(); - vkSubmitInfo.pWaitSemaphores = waitSemaphoreList; + vkSubmitInfo.pWaitSemaphores = waitSemaphoreList(); vkSubmitInfo.pWaitDstStageMask = vkPipelineStageFlagsList.data(); vkSubmitInfo.commandBufferCount = (uint32_t)commandBufferList.size(); - vkSubmitInfo.pCommandBuffers = commandBufferList; + vkSubmitInfo.pCommandBuffers = commandBufferList(); vkSubmitInfo.signalSemaphoreCount = (uint32_t)signalSemaphoreList.size(); - vkSubmitInfo.pSignalSemaphores = signalSemaphoreList; + vkSubmitInfo.pSignalSemaphores = signalSemaphoreList(); vkQueueSubmit(m_vkQueue, 1, &vkSubmitInfo, NULL); } @@ -729,7 +729,8 @@ void VulkanDescriptorSetLayout::VulkanDescriptorSetLayoutCommon( vkDescriptorSetLayoutCreateInfo.flags = 0; vkDescriptorSetLayoutCreateInfo.bindingCount = (uint32_t)descriptorSetLayoutBindingList.size(); - vkDescriptorSetLayoutCreateInfo.pBindings = descriptorSetLayoutBindingList; + vkDescriptorSetLayoutCreateInfo.pBindings = + descriptorSetLayoutBindingList(); vkCreateDescriptorSetLayout(m_device, &vkDescriptorSetLayoutCreateInfo, NULL, &m_vkDescriptorSetLayout); @@ -800,7 +801,7 @@ void VulkanPipelineLayout::VulkanPipelineLayoutCommon( vkPipelineLayoutCreateInfo.flags = 0; vkPipelineLayoutCreateInfo.setLayoutCount = (uint32_t)descriptorSetLayoutList.size(); - vkPipelineLayoutCreateInfo.pSetLayouts = descriptorSetLayoutList; + vkPipelineLayoutCreateInfo.pSetLayouts = descriptorSetLayoutList(); vkPipelineLayoutCreateInfo.pushConstantRangeCount = 0; vkPipelineLayoutCreateInfo.pPushConstantRanges = NULL; @@ -1573,7 +1574,7 @@ VulkanImage::VulkanImage( vkImageCreateInfo.queueFamilyIndexCount = (uint32_t)m_device.getPhysicalDevice().getQueueFamilyList().size(); vkImageCreateInfo.pQueueFamilyIndices = - m_device.getPhysicalDevice().getQueueFamilyList(); + m_device.getPhysicalDevice().getQueueFamilyList()(); vkImageCreateInfo.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED; VkExternalMemoryImageCreateInfo vkExternalMemoryImageCreateInfo = {};