ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-26 08:49:02 +00:00
Code Packages Projects Releases Wiki Activity

[NFC] Fix BasicCommandBufferTest initialization order (#1628)

Browse Source 
The `command_buffer` member is initialized with `this`, and should
thus be initialized after all other members have been initialized, to
avoid any potential uninitialized data accesses by `command_buffer`'s
constructor.  This is currently not a problem, but would become a
problem when `command_buffer`'s constructor accesses the object
through its parameter.

Fixes a -Wreorder warning.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2023-02-20 11:39:18 +00:00
committed by GitHub
parent 560d6eafbd
commit 61ec521b1c
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test_conformance/extensions/cl_khr_command_buffer/basic_command_buffer.cpp
View File

@@ -25,12 +25,12 @@ BasicCommandBufferTest::BasicCommandBufferTest(cl_device_id device,
cl_context context, cl_context context,
cl_command_queue queue) cl_command_queue queue)
: CommandBufferTestBase(device), context(context), queue(nullptr), : CommandBufferTestBase(device), context(context), queue(nullptr),
num_elements(0), command_buffer(this), simultaneous_use_support(false), num_elements(0), simultaneous_use_support(false),
out_of_order_support(false), out_of_order_support(false),
// try to use simultaneous path by default // try to use simultaneous path by default
simultaneous_use_requested(true), simultaneous_use_requested(true),
// due to simultaneous cases extend buffer size // due to simultaneous cases extend buffer size
buffer_size_multiplier(1) buffer_size_multiplier(1), command_buffer(this)
{ {
cl_int error = clRetainCommandQueue(queue); cl_int error = clRetainCommandQueue(queue);

2
test_conformance/extensions/cl_khr_command_buffer/basic_command_buffer.h
View File

@@ -53,7 +53,6 @@ protected:
cl_context context; cl_context context;
clCommandQueueWrapper queue; clCommandQueueWrapper queue;
clCommandBufferWrapper command_buffer;
clProgramWrapper program; clProgramWrapper program;
clKernelWrapper kernel; clKernelWrapper kernel;
clMemWrapper in_mem, out_mem, off_mem; clMemWrapper in_mem, out_mem, off_mem;
@@ -66,6 +65,7 @@ protected:
// user request for simultaneous use // user request for simultaneous use
bool simultaneous_use_requested; bool simultaneous_use_requested;
unsigned buffer_size_multiplier; unsigned buffer_size_multiplier;
clCommandBufferWrapper command_buffer;
}; };
template <class T> template <class T>