ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-26 00:39:03 +00:00
Code Packages Projects Releases Wiki Activity

Use cl_uint in some SPIR-V tests to avoid UB (#2159)

Browse Source 
The following tests under `spirv_new`:
* `op_branch_conditional`
* `op_phi`
* `op_selection_merge`

were using randomly generated `cl_int` values, and storing the
difference between them as a `cl_int`. If one of the generated values is
negative and large enough, while the other is positive and large enough,
the difference then becomes a larger value that cannot be represented
using `cl_int`.

Switch the tests to use `cl_uint` instead, and update the relevant
spvasm{32,64} files to use `OpULessThan` instead of `OpSLessThan`.

Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
This commit is contained in:
Ahmed Hesham
2024-11-26 17:29:27 +00:00
committed by GitHub
parent 96e3d7e669
commit 5d85fb3e3b
19 changed files with 84 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test_conformance/spirv_new/spirv_asm/phi_2.spvasm64
View File

@@ -41,7 +41,7 @@
%22 = OpLoad %uint %21 Aligned 4
%23 = OpInBoundsPtrAccessChain %_ptr_CrossWorkgroup_uint %rhs %20
%24 = OpLoad %uint %23 Aligned 4
%25 = OpSLessThan %bool %22 %24
%25 = OpULessThan %bool %22 %24
OpBranchConditional %25 %26 %27
%26 = OpLabel
%28 = OpISub %uint %24 %22