ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 16:29:03 +00:00
Code Packages Projects Releases Wiki Activity

Escape subnormal values (#1953)

Browse Source 
Currently we don't escape subnormal values when generating image data.
In sampler read tests, we use `!=` to check the two values even when it
is floating-point data, which requires the two values are bitwise equal.
However, a sampler might flush subnormal values, causing the test case
to fail.

In this patch, when generating random image data, we escape subnormal
values.
This commit is contained in:
Shilei Tian
2024-05-30 18:19:00 -04:00
committed by GitHub
parent 75be6a3125
commit 556025ba14
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test_common/harness/imageHelpers.cpp
View File

@@ -1128,13 +1128,15 @@ cl_ulong get_image_size_mb(image_descriptor const *imageInfo)
uint64_t gRoundingStartValue = 0; uint64_t gRoundingStartValue = 0;
void escape_inf_nan_values(char *data, size_t allocSize) void escape_inf_nan_subnormal_values(char *data, size_t allocSize)
{ {
// filter values with 8 not-quite-highest bits // filter values with 8 not-quite-highest bits
unsigned int *intPtr = (unsigned int *)data; unsigned int *intPtr = (unsigned int *)data;
for (size_t i = 0; i<allocSize>> 2; i++) for (size_t i = 0; i<allocSize>> 2; i++)
{ {
if ((intPtr[i] & 0x7F800000) == 0x7F800000) intPtr[i] ^= 0x40000000; if ((intPtr[i] & 0x7F800000) == 0x7F800000) intPtr[i] ^= 0x40000000;
else if ((intPtr[i] & 0x7F800000) == 0)
intPtr[i] ^= 0x40000000;
} }
// Ditto with half floats (16-bit numbers with the 5 not-quite-highest bits // Ditto with half floats (16-bit numbers with the 5 not-quite-highest bits
@@ -1143,6 +1145,8 @@ void escape_inf_nan_values(char *data, size_t allocSize)
for (size_t i = 0; i<allocSize>> 1; i++) for (size_t i = 0; i<allocSize>> 1; i++)
{ {
if ((shortPtr[i] & 0x7C00) == 0x7C00) shortPtr[i] ^= 0x4000; if ((shortPtr[i] & 0x7C00) == 0x7C00) shortPtr[i] ^= 0x4000;
else if ((shortPtr[i] & 0x7C00) == 0)
shortPtr[i] ^= 0x4000;
} }
} }
@@ -1221,7 +1225,7 @@ char *generate_random_image_data(image_descriptor *imageInfo,
// Note: inf or nan float values would cause problems, although we don't // Note: inf or nan float values would cause problems, although we don't
// know this will actually be a float, so we just know what to look for // know this will actually be a float, so we just know what to look for
escape_inf_nan_values(data, allocSize); escape_inf_nan_subnormal_values(data, allocSize);
return data; return data;
} }
@@ -1233,7 +1237,7 @@ char *generate_random_image_data(image_descriptor *imageInfo,
// Note: inf or nan float values would cause problems, although we don't // Note: inf or nan float values would cause problems, although we don't
// know this will actually be a float, so we just know what to look for // know this will actually be a float, so we just know what to look for
escape_inf_nan_values(data, allocSize); escape_inf_nan_subnormal_values(data, allocSize);
if (/*!gTestMipmaps*/ imageInfo->num_mip_levels < 2) if (/*!gTestMipmaps*/ imageInfo->num_mip_levels < 2)
{ {