ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 08:19:02 +00:00
Code Packages Projects Releases Wiki Activity

test_common: fix -Wsign-compare warnings (#1759)

Browse Source 
In preparation of re-enabling `-Wsign-compare` globally, avoid mixing
signed and unsigned integers in comparisons in test_common.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2023-06-21 15:19:21 +01:00
committed by GitHub
parent df3ec8deec
commit 50f9f06323
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test_common/gl/helpers.cpp
View File

@@ -1715,7 +1715,7 @@ void * CreateGLRenderbuffer( GLsizei width, GLsizei height,
// Reverse and reorder to validate since in the // Reverse and reorder to validate since in the
// kernel the read_imagef() call always returns RGBA // kernel the read_imagef() call always returns RGBA
cl_uchar *p = (cl_uchar *)buffer; cl_uchar *p = (cl_uchar *)buffer;
for( size_t i = 0; i < (size_t)width * height; i++ ) for (GLsizei i = 0; i < width * height; i++)
{ {
cl_uchar uc0 = p[i * 4 + 0]; cl_uchar uc0 = p[i * 4 + 0];
cl_uchar uc1 = p[i * 4 + 1]; cl_uchar uc1 = p[i * 4 + 1];
@@ -1733,7 +1733,7 @@ void * CreateGLRenderbuffer( GLsizei width, GLsizei height,
// Reverse and reorder to validate since in the // Reverse and reorder to validate since in the
// kernel the read_imagef() call always returns RGBA // kernel the read_imagef() call always returns RGBA
cl_uchar *p = (cl_uchar *)buffer; cl_uchar *p = (cl_uchar *)buffer;
for( size_t i = 0; i < width * height; i++ ) for (GLsizei i = 0; i < width * height; i++)
{ {
cl_uchar uc0 = p[i * 4 + 0]; cl_uchar uc0 = p[i * 4 + 0];
cl_uchar uc1 = p[i * 4 + 1]; cl_uchar uc1 = p[i * 4 + 1];

4
test_common/harness/testHarness.cpp
View File

@@ -835,9 +835,9 @@ void callTestFunctions(test_definition testList[],
std::vector<std::thread *> threads; std::vector<std::thread *> threads;
test_harness_state state = { testList, resultTestList, deviceToUse, test_harness_state state = { testList, resultTestList, deviceToUse,
config }; config };
for (int i = 0; i < config.numWorkerThreads; i++) for (unsigned i = 0; i < config.numWorkerThreads; i++)
{ {
log_info("Spawning worker thread %i\n", i); log_info("Spawning worker thread %u\n", i);
threads.push_back(new std::thread(test_function_runner, &state)); threads.push_back(new std::thread(test_function_runner, &state));
} }