From 4f62adf1ca2cadc864dac844e643a20aa8b76b29 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Tue, 23 May 2023 09:43:25 +0100 Subject: [PATCH] computeinfo: fix use of uninitialized config_size_ret (#1727) The variable `config_size_ret` is only assigned to inside the `if`. If the condition is false, we would read uninitialized data. Signed-off-by: Sven van Haastregt --- test_conformance/computeinfo/main.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test_conformance/computeinfo/main.cpp b/test_conformance/computeinfo/main.cpp index 9cecabea..b1d73af3 100644 --- a/test_conformance/computeinfo/main.cpp +++ b/test_conformance/computeinfo/main.cpp @@ -439,8 +439,8 @@ int getPlatformConfigInfo(cl_platform_id platform, config_info* info) err = clGetPlatformInfo(platform, info->opcode, config_size_set, &info->config.cl_name_version_single, &config_size_ret); + size_err = config_size_set != config_size_ret; } - size_err = config_size_set != config_size_ret; break; default: log_error("Unknown config type: %d\n", info->config_type); @@ -585,8 +585,8 @@ int getConfigInfo(cl_device_id device, config_info* info) err = clGetDeviceInfo(device, info->opcode, config_size_set, &info->config.cl_name_version_single, &config_size_ret); + size_err = config_size_set != config_size_ret; } - size_err = config_size_set != config_size_ret; break; default: log_error("Unknown config type: %d\n", info->config_type);