ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NFC] subgroups: clarify bs128 to uint4 conversion (#1893)

Browse Source 
There appears to have been some confusion over `uint_mask` during the
initial reviews of the subgroup tests.  Add a comment to clarify the
purpose of the mask.

Use a 32-bit all-ones mask (`0xffffffff`) instead of a 64-bit all-ones
mask to further clarify the intent, that is, don't delay discarding
the upper 32 bits until the assignment but mask them out immediately.

Fixes https://github.com/KhronosGroup/OpenCL-CTS/issues/1203

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2024-04-04 15:12:10 +02:00
committed by GitHub
parent 7f1caf4aa9
commit 48003e9d32
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test_conformance/subgroups/subhelpers.cpp
View File

@@ -102,8 +102,9 @@ cl_uint4 generate_bit_mask(cl_uint subgroup_local_id,
if (mask_type == "gt") mask128.reset(pos); if (mask_type == "gt") mask128.reset(pos);
} }
// convert std::bitset<128> to uint4 // convert std::bitset<128> to uint4.
auto const uint_mask = bs128{ static_cast<unsigned long>(-1) }; // Use a mask to avoid std::overflow_error from to_ulong().
auto const uint_mask = bs128{ 0xffffffff };
mask.s0 = (mask128 & uint_mask).to_ulong(); mask.s0 = (mask128 & uint_mask).to_ulong();
mask128 >>= 32; mask128 >>= 32;
mask.s1 = (mask128 & uint_mask).to_ulong(); mask.s1 = (mask128 & uint_mask).to_ulong();