ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 00:09:02 +00:00
Code Packages Projects Releases Wiki Activity

math_brute_force: remove gotos in macro_unary_float (#1725)

Browse Source 
Simplify code by returning directly instead of using goto statements.

Although intended as an NFC commit, this changes the behaviour when
verification fails: the output buffer is no longer unmapped.  Although
not ideal, this aligns the behaviour of `macro_unary_float` to the
other math_brute_force tests.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2023-09-06 13:32:19 +01:00
committed by GitHub
parent d20de8ddea
commit 39cca992b8
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test_conformance/math_brute_force/macro_unary_float.cpp
View File

@@ -81,7 +81,6 @@ cl_int Test(cl_uint job_id, cl_uint thread_id, void *data)
int ftz = job->ftz; int ftz = job->ftz;
bool relaxedMode = job->relaxedMode; bool relaxedMode = job->relaxedMode;
cl_int error = CL_SUCCESS; cl_int error = CL_SUCCESS;
cl_int ret = CL_SUCCESS;
const char *name = job->f->name; const char *name = job->f->name;
int signbit_test = 0; int signbit_test = 0;
@@ -245,8 +244,7 @@ cl_int Test(cl_uint job_id, cl_uint thread_id, void *data)
if (q[j] > t[j]) err = q[j] - t[j]; if (q[j] > t[j]) err = q[j] - t[j];
vlog_error("\nERROR: %s: %d ulp error at %a: *%d vs. %d\n", vlog_error("\nERROR: %s: %d ulp error at %a: *%d vs. %d\n",
name, err, ((float *)s)[j], t[j], q[j]); name, err, ((float *)s)[j], t[j], q[j]);
error = -1; return -1;
goto exit;
} }
@@ -272,15 +270,12 @@ cl_int Test(cl_uint job_id, cl_uint thread_id, void *data)
vlog_error( vlog_error(
"\nERROR: %s%s: %d ulp error at %a: *%d vs. %d\n", name, "\nERROR: %s%s: %d ulp error at %a: *%d vs. %d\n", name,
sizeNames[k], err, ((float *)s)[j], -t[j], q[j]); sizeNames[k], err, ((float *)s)[j], -t[j], q[j]);
error = -1; return -1;
goto exit;
} }
} }
} }
} }
exit:
ret = error;
for (auto j = gMinVectorSizeIndex; j < gMaxVectorSizeIndex; j++) for (auto j = gMinVectorSizeIndex; j < gMaxVectorSizeIndex; j++)
{ {
if ((error = clEnqueueUnmapMemObject(tinfo->tQueue, tinfo->outBuf[j], if ((error = clEnqueueUnmapMemObject(tinfo->tQueue, tinfo->outBuf[j],
@@ -315,7 +310,7 @@ exit:
fflush(stdout); fflush(stdout);
} }
return ret; return CL_SUCCESS;
} }
} // anonymous namespace } // anonymous namespace