ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix test_select verification failure reporting (#1462)

Browse Source 
When verification of the computed result fails, the test would still
report as "passed".  This is because `s_test_fail` is only written to
and never read.

Fix the immediate issue by returning a failure value and incrementing
`gFailCount` if any error was detected.  The error handling can be
improved further, but I'm leaving that out of the scope of this fix.

Fixes https://github.com/KhronosGroup/OpenCL-CTS/issues/1445

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2022-08-04 15:05:10 +01:00
committed by GitHub
parent 4ee8022230
commit 38639f229d
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test_conformance/select/test_select.cpp
View File

@@ -79,7 +79,6 @@ static int s_wimpy_reduction_factor = 256;
// sub tests which is for each individual test. The following // sub tests which is for each individual test. The following
// tracks the subtests // tracks the subtests
int s_test_cnt = 0; int s_test_cnt = 0;
int s_test_fail = 0;
//----------------------------------------- //-----------------------------------------
// Static helper functions // Static helper functions
@@ -297,6 +296,7 @@ static cl_program makeSelectProgram(cl_kernel *kernel_ptr, const cl_context cont
static int doTest(cl_command_queue queue, cl_context context, Type stype, Type cmptype, cl_device_id device) static int doTest(cl_command_queue queue, cl_context context, Type stype, Type cmptype, cl_device_id device)
{ {
int err = CL_SUCCESS; int err = CL_SUCCESS;
int s_test_fail = 0;
MTdata d; MTdata d;
const size_t element_count[VECTOR_SIZE_COUNT] = { 1, 2, 3, 4, 8, 16 }; const size_t element_count[VECTOR_SIZE_COUNT] = { 1, 2, 3, 4, 8, 16 };
cl_mem src1 = NULL; cl_mem src1 = NULL;
@@ -468,6 +468,11 @@ exit:
clReleaseProgram(programs[vecsize]); clReleaseProgram(programs[vecsize]);
} }
++s_test_cnt; ++s_test_cnt;
if (s_test_fail)
{
err = TEST_FAIL;
gFailCount++;
}
return err; return err;
} }