From 34feb6e0082b6890f57a91523dac18d28131bb34 Mon Sep 17 00:00:00 2001 From: Karol Herbst Date: Tue, 7 Jan 2025 18:35:46 +0100 Subject: [PATCH] svm: finish all queues in svm_pointer_passing (#2209) The `svm_pointer_passing` test has unflushed buffer unmap commands queued, which a runtime might process after the `clSVMFree` calls at the end of the test (through implicit flushing when destroying the queues at e.g. program exit handlers). This is only an issue when running the test with multiple devices. However I think this was caused by a simple typo given the `clFinish` was simply in the wrong block. --- test_conformance/SVM/test_pointer_passing.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test_conformance/SVM/test_pointer_passing.cpp b/test_conformance/SVM/test_pointer_passing.cpp index d1aa5005..aa1df4eb 100644 --- a/test_conformance/SVM/test_pointer_passing.cpp +++ b/test_conformance/SVM/test_pointer_passing.cpp @@ -127,10 +127,10 @@ REGISTER_TEST(svm_pointer_passing) return -1; } } - } - error = clFinish(cmdq); - test_error(error, "clFinish failed"); + error = clFinish(cmdq); + test_error(error, "clFinish failed"); + } }