ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 16:29:03 +00:00
Code Packages Projects Releases Wiki Activity

fix test kernel attributes when api fcts are failing (#1449)

Browse Source 
test_error returns the err given as the first argument. As the
run_test function returns a bool, we end up returning true (meaning
pass) when an api function fails.
Instead return explicitly false (meaning fail).
This commit is contained in:
Romaric Jodin
2022-09-01 07:56:10 +02:00
committed by GitHub
parent f94c135755
commit 2dc2533130
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test_conformance/api/test_kernel_attributes.cpp
View File

@@ -275,16 +275,16 @@ static bool run_test(cl_context context, cl_device_id deviceID,
clKernelWrapper kernel; clKernelWrapper kernel;
cl_int err = create_single_kernel_helper(context, &program, &kernel, 1, cl_int err = create_single_kernel_helper(context, &program, &kernel, 1,
&kernel_src, "test_kernel"); &kernel_src, "test_kernel");
test_error(err, "create_single_kernel_helper"); test_error_ret(err, "create_single_kernel_helper", false);
// Get the size of the kernel attribute string returned // Get the size of the kernel attribute string returned
size_t size = 0; size_t size = 0;
err = clGetKernelInfo(kernel, CL_KERNEL_ATTRIBUTES, 0, nullptr, &size); err = clGetKernelInfo(kernel, CL_KERNEL_ATTRIBUTES, 0, nullptr, &size);
test_error(err, "clGetKernelInfo"); test_error_ret(err, "clGetKernelInfo", false);
std::vector<char> attributes(size); std::vector<char> attributes(size);
err = clGetKernelInfo(kernel, CL_KERNEL_ATTRIBUTES, attributes.size(), err = clGetKernelInfo(kernel, CL_KERNEL_ATTRIBUTES, attributes.size(),
attributes.data(), nullptr); attributes.data(), nullptr);
test_error(err, "clGetKernelInfo"); test_error_ret(err, "clGetKernelInfo", false);
std::string attribute_string(attributes.data()); std::string attribute_string(attributes.data());
attribute_string.erase( attribute_string.erase(
std::remove(attribute_string.begin(), attribute_string.end(), ' '), std::remove(attribute_string.begin(), attribute_string.end(), ' '),