ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-26 08:49:02 +00:00
Code Packages Projects Releases Wiki Activity

Fix -Woverloaded-virtual warnings (#1599)

Browse Source 
Align `verify_data` with `checker_image_mem_host_read_only.hpp`, that
is, take an explicit pointer to compare against.

Add a missing (but unused) `float` parameter to
`KernelArgSampler::compare`.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
This commit is contained in:
Sven van Haastregt
2023-01-27 16:34:22 +00:00
committed by GitHub
parent 9eec8f3352
commit 2cc8e2e593
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test_conformance/mem_host_flags/checker_image_mem_host_write_only.hpp
View File

@@ -38,7 +38,7 @@ public:
cl_int Setup_Test_Environment(); cl_int Setup_Test_Environment();
cl_int update_host_mem_2(); cl_int update_host_mem_2();
cl_int verify_data(); cl_int verify_data(T *pdtaIn);
}; };
template <class T> template <class T>
@@ -108,12 +108,13 @@ cl_int cImage_check_mem_host_write_only<T>::update_host_mem_2()
return err; return err;
} }
template <class T> cl_int cImage_check_mem_host_write_only<T>::verify_data() template <class T>
cl_int cImage_check_mem_host_write_only<T>::verify_data(T *pdtaIn)
{ {
cl_int err = CL_SUCCESS; cl_int err = CL_SUCCESS;
if (!this->host_m_1.Equal_rect_from_orig( if (!this->host_m_1.Equal_rect_from_orig(pdtaIn, this->buffer_origin,
this->host_m_2, this->buffer_origin, this->region, this->region, this->host_row_pitch,
this->host_row_pitch, this->host_slice_pitch)) this->host_slice_pitch))
{ {
log_error("Image and host data difference found\n"); log_error("Image and host data difference found\n");
return FAILURE; return FAILURE;
@@ -178,8 +179,9 @@ template <class T> cl_int cImage_check_mem_host_write_only<T>::verify_RW_Image()
update_host_mem_2(); // Read buffer contents into mem_2 update_host_mem_2(); // Read buffer contents into mem_2
err = err = this->verify_data(
this->verify_data(); // Compare the contents of mem_2 and mem_1, this->host_m_2
.pData); // Compare the contents of mem_2 and mem_1,
// mem_1 is same as mem_0 in setup test environment // mem_1 is same as mem_0 in setup test environment
test_error(err, "verify_data error"); test_error(err, "verify_data error");

2
test_conformance/spir/kernelargs.h
View File

@@ -232,7 +232,7 @@ public:
return &m_samplerObj; return &m_samplerObj;
} }
bool compare( const KernelArg& rhs ) const bool compare(const KernelArg& rhs, float) const
{ {
if (const KernelArgSampler *Rhs = dynamic_cast<const KernelArgSampler*>(&rhs)) if (const KernelArgSampler *Rhs = dynamic_cast<const KernelArgSampler*>(&rhs))
{ {