From 27e47e9e878bb58cf1747f71e0813c07eab07f27 Mon Sep 17 00:00:00 2001 From: Ben Ashbaugh Date: Thu, 4 Apr 2024 13:08:41 -0700 Subject: [PATCH] fix the type used for bitfield_extract_signed (#1913) We compute the reference values using unsigned types exclusively, even when the input type is signed. This fixes one place where an signed type was inadvertently used. --- test_conformance/integer_ops/test_extended_bit_ops_extract.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_conformance/integer_ops/test_extended_bit_ops_extract.cpp b/test_conformance/integer_ops/test_extended_bit_ops_extract.cpp index 9b4e0950..b9657fcb 100644 --- a/test_conformance/integer_ops/test_extended_bit_ops_extract.cpp +++ b/test_conformance/integer_ops/test_extended_bit_ops_extract.cpp @@ -44,7 +44,7 @@ template static typename std::make_unsigned::type cpu_bit_extract_signed(T tbase, cl_uint offset, cl_uint count) { - typedef typename std::make_signed::type unsigned_t; + typedef typename std::make_unsigned::type unsigned_t; assert(offset <= sizeof(T) * 8); assert(count <= sizeof(T) * 8);