ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-19 06:09:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup usage of static, extern and typedef (#1256)

Browse Source 
* Cleanup usage of static, extern and typedef

Remove static on functions defined headers, as it can result in
duplication in binaries.

Remove unnecessary extern keyword on a function declaration, as it is
the default behavior and can be puzzling when reading the code.

Remove the unused declaration of my_ilogb, which is never defined.

Remove unnecessary usage of typedef, as they are only increasing the
cognitive load of the code for no purpose.

Signed-off-by: Marco Antognini <marco.antognini@arm.com>

* Improve usage of inline and static in harness

Functions declared in header as static can trigger unused warnings when
(indirectly) included in translation units that do not use such
functions. Use inline instead, which also avoids duplicating symbols in
binaries.

Signed-off-by: Marco Antognini <marco.antognini@arm.com>
This commit is contained in:
Marco Antognini
2021-05-18 18:09:46 +01:00
committed by GitHub
parent 6572837994
commit 17a0d09567
6 changed files with 37 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test_conformance/math_brute_force/reference_math.cpp
View File

@@ -41,10 +41,10 @@
#pragma STDC FP_CONTRACT OFF
static void __log2_ep(double *hi, double *lo, double x);
typedef union {
union uint64d_t {
uint64_t i;
double d;
} uint64d_t;
};
static const uint64d_t _CL_NAN = { 0x7ff8000000000000ULL };
@@ -2259,10 +2259,10 @@ long double reference_dividel(long double x, long double y)
return dx / dy;
}
typedef struct
struct double_double
{
double hi, lo;
} double_double;
};
// Split doubles_double into a series of consecutive 26-bit precise doubles and
// a remainder. Note for later -- for multiplication, it might be better to
@@ -3767,10 +3767,10 @@ static uint32_t two_over_pi[] = {
static uint32_t pi_over_two[] = { 0x1, 0x2487ed51, 0x42d1846,
0x26263314, 0x1701b839, 0x28948127 };
typedef union {
union d_ui64_t {
uint64_t u;
double d;
} d_ui64_t;
};
// radix or base of representation
#define RADIX (30)
@@ -3786,13 +3786,13 @@ d_ui64_t two_pow_two_mradix = { (uint64_t)(1023 - 2 * RADIX) << 52 };
// extended fixed point representation of double precision
// floating point number.
// x = sign * [ sum_{i = 0 to 2} ( X[i] * 2^(index - i)*RADIX ) ]
typedef struct
struct eprep_t
{
uint32_t X[3]; // three 32 bit integers are sufficient to represnt double in
// base_30
int index; // exponent bias
int sign; // sign of double
} eprep_t;
};
static eprep_t double_to_eprep(double x)
{