ahmed/OpenCL-CTS
1
0
Fork 0
mirror of https://github.com/KhronosGroup/OpenCL-CTS.git synced 2026-03-25 16:29:03 +00:00
Code Packages Projects Releases Wiki Activity

Remove duplicate IsXSubnormal functions (#826)

Browse Source 
* Remove duplicate IsXSubnormal functions

Is{Double,FLoat,Half}Subnormal function duplicates are currently in the codebase.

Fixes #511

Change-Id: Ibe97f20a6e38db6aed00c9ba397cfa72036bd1c5
Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>

* Update conversions.h
This commit is contained in:
ellnor01
2020-06-17 10:14:33 +01:00
committed by GitHub
parent 4f4950feee
commit 164b5ef5cf
3 changed files with 4 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test_common/harness/conversions.h
View File

@@ -115,6 +115,7 @@ static inline int IsDoubleSubnormal( double x )
static inline int IsHalfSubnormal( cl_half x ) static inline int IsHalfSubnormal( cl_half x )
{ {
// this relies on interger overflow to exclude 0 as a subnormal
return ( ( x & 0x7fffU ) - 1U ) < 0x03ffU; return ( ( x & 0x7fffU ) - 1U ) < 0x03ffU;
} }

38
test_conformance/half/cl_utils.h
View File

@@ -18,6 +18,7 @@
#include "harness/testHarness.h" #include "harness/testHarness.h"
#include "harness/compat.h" #include "harness/compat.h"
#include "harness/conversions.h"
#include <stdio.h> #include <stdio.h>
@@ -109,43 +110,6 @@ static inline cl_ulong DoubleFromUInt( cl_uint bits )
return u; return u;
} }
static inline int IsHalfSubnormal( uint16_t x )
{
// this relies on interger overflow to exclude 0 as a subnormal
return ( ( x & 0x7fffU ) - 1U ) < 0x03ffU;
}
// prevent silent failures due to missing FLT_RADIX
#ifndef FLT_RADIX
#error FLT_RADIX is not defined by float.h
#endif
static inline int IsFloatSubnormal( double x )
{
#if 2 == FLT_RADIX
// Do this in integer to avoid problems with FTZ behavior
union{ float d; uint32_t u;}u;
u.d = fabsf((float) x);
return (u.u-1) < 0x007fffffU;
#else
// rely on floating point hardware for non-radix2 non-IEEE-754 hardware -- will fail if you flush subnormals to zero
return fabs(x) < (double) FLT_MIN && x != 0.0;
#endif
}
static inline int IsDoubleSubnormal( long double x )
{
#if 2 == FLT_RADIX
// Do this in integer to avoid problems with FTZ behavior
union{ double d; uint64_t u;}u;
u.d = fabs((double)x);
return (u.u-1) < 0x000fffffffffffffULL;
#else
// rely on floating point hardware for non-radix2 non-IEEE-754 hardware -- will fail if you flush subnormals to zero
return fabs(x) < (double) DBL_MIN && x != 0.0;
#endif
}
#endif /* CL_UTILS_H */ #endif /* CL_UTILS_H */

29
test_conformance/math_brute_force/Utility.h
View File

@@ -28,6 +28,7 @@
#include "harness/fpcontrol.h" #include "harness/fpcontrol.h"
#include "harness/testHarness.h" #include "harness/testHarness.h"
#include "harness/ThreadPool.h" #include "harness/ThreadPool.h"
#include "harness/conversions.h"
#define BUFFER_SIZE (1024*1024*2) #define BUFFER_SIZE (1024*1024*2)
#if defined( __GNUC__ ) #if defined( __GNUC__ )
@@ -124,34 +125,6 @@ void _LogBuildError( cl_program p, int line, const char *file );
#define PERF_LOOP_COUNT 100 #define PERF_LOOP_COUNT 100
// Note: though this takes a double, this is for use with single precision tests
static inline int IsFloatSubnormal( double x )
{
#if 2 == FLT_RADIX
// Do this in integer to avoid problems with FTZ behavior
union{ float d; uint32_t u;}u;
u.d = fabsf((float)x);
return (u.u-1) < 0x007fffffU;
#else
// rely on floating point hardware for non-radix2 non-IEEE-754 hardware -- will fail if you flush subnormals to zero
return fabs(x) < (double) FLT_MIN && x != 0.0;
#endif
}
static inline int IsDoubleSubnormal( long double x )
{
#if 2 == FLT_RADIX
// Do this in integer to avoid problems with FTZ behavior
union{ double d; uint64_t u;}u;
u.d = fabs((double) x);
return (u.u-1) < 0x000fffffffffffffULL;
#else
// rely on floating point hardware for non-radix2 non-IEEE-754 hardware -- will fail if you flush subnormals to zero
return fabs(x) < (double) DBL_MIN && x != 0.0;
#endif
}
//The spec is fairly clear that we may enforce a hard cutoff to prevent premature flushing to zero. //The spec is fairly clear that we may enforce a hard cutoff to prevent premature flushing to zero.
// However, to avoid conflict for 1.0, we are letting results at TYPE_MIN + ulp_limit to be flushed to zero. // However, to avoid conflict for 1.0, we are letting results at TYPE_MIN + ulp_limit to be flushed to zero.
static inline int IsFloatResultSubnormal( double x, float ulps ) static inline int IsFloatResultSubnormal( double x, float ulps )